Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/shared-expanded-subflows-list #2115

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

brian-mulier-p
Copy link
Member

@brian-mulier-p brian-mulier-p commented Sep 14, 2023

It allows the Topology tab & EditorView's topology to share their expanded subflows' list to prevent having multiple call for an already expanded subflow which results in unconnected node when expanding a subflow from one tab and going to the other and do the same
image

As said, wondering if I should use Vuex instead

@brian-mulier-p brian-mulier-p self-assigned this Sep 14, 2023
ui/src/components/flows/FlowRoot.vue Outdated Show resolved Hide resolved
@brian-mulier-p brian-mulier-p force-pushed the fix/shared-expanded-subflows-list branch 3 times, most recently from 68a4ad3 to 0ce3aa8 Compare September 14, 2023 15:09
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p force-pushed the fix/shared-expanded-subflows-list branch from 0ce3aa8 to cdc3670 Compare September 14, 2023 15:39
@brian-mulier-p brian-mulier-p force-pushed the fix/shared-expanded-subflows-list branch from cdc3670 to 0f5f4e0 Compare September 14, 2023 15:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@brian-mulier-p brian-mulier-p merged commit 1b72943 into develop Sep 14, 2023
@brian-mulier-p brian-mulier-p deleted the fix/shared-expanded-subflows-list branch September 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants