Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/subflow-tasks-attempts #2099

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

brian-mulier-p
Copy link
Member

closes #2098

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems legit but can you explain why it is needed now and works without before?

@brian-mulier-p
Copy link
Member Author

brian-mulier-p commented Sep 13, 2023

I explained it quickly on the issue but attempts are not really used (or at least in this case subflow almost never fail so you don't need to replay the task itself) except for logs display and not having attempt on "Flow" tasks makes it an edge case

@brian-mulier-p brian-mulier-p force-pushed the fix/subflow-tasks-attempts branch from 395c13e to 0f5ff16 Compare September 13, 2023 09:18
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just long one line are not very readable

@brian-mulier-p brian-mulier-p force-pushed the fix/subflow-tasks-attempts branch from 0f5ff16 to 770a5e6 Compare September 13, 2023 17:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@brian-mulier-p brian-mulier-p merged commit ad54f84 into develop Sep 13, 2023
@brian-mulier-p brian-mulier-p deleted the fix/subflow-tasks-attempts branch September 13, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subflow task logs are not shown
3 participants