Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/error-message-on-graph-generation-fail #2097

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix/error-message-on-graph-generation-fail #2097

merged 1 commit into from
Sep 19, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1423

@brian-mulier-p brian-mulier-p self-assigned this Sep 12, 2023
@brian-mulier-p brian-mulier-p force-pushed the fix/error-message-on-graph-generation-fail branch 4 times, most recently from b1bfd1f to 6f1e26a Compare September 12, 2023 15:51
@brian-mulier-p
Copy link
Member Author

brian-mulier-p commented Sep 12, 2023 •
edited
Loading

2 things here:

  • I added setting back flow & flowGraph to undefined after unmounting FlowRoot & ExecutionRoot as it was not done and eventually overflowing over other flow when switching out as the error message is based on the flowGraph being absent (whatever it still better to reset any flow / execution state after those components are unmounting)
  • I wanted to also test the deserialization issue handling part from the controller but I don't know how to do it as I need some flow with unknown type to be inserted in database and validations are everywhere (and I don't want to change accessibility of inner methods to bypass protections just for the tests)

@brian-mulier-p brian-mulier-p force-pushed the fix/error-message-on-graph-generation-fail branch 2 times, most recently from cdf51a7 to 3696531 Compare September 14, 2023 16:08
@tchiotludo tchiotludo force-pushed the fix/error-message-on-graph-generation-fail branch from 3696531 to 25f28fe Compare September 15, 2023 07:03
@brian-mulier-p brian-mulier-p force-pushed the fix/error-message-on-graph-generation-fail branch 2 times, most recently from bb3ee7f to c2f706d Compare September 18, 2023 11:10
Skraye
Skraye approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchiotludo tchiotludo force-pushed the fix/error-message-on-graph-generation-fail branch from c2f706d to 3afdc0e Compare September 18, 2023 20:27
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.4% 71.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@brian-mulier-p brian-mulier-p merged commit 0a1b772 into develop Sep 19, 2023
@brian-mulier-p brian-mulier-p deleted the fix/error-message-on-graph-generation-fail branch September 19, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow with invalid type generate an empty graph
2 participants
@brian-mulier-p @Skraye