Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/flow-triggers-without-condition #2061

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix/flow-triggers-without-condition #2061

merged 1 commit into from
Sep 8, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #2060

@brian-mulier-p brian-mulier-p self-assigned this Sep 8, 2023
@brian-mulier-p
Copy link
Member Author

Just adding a flow with Flow trigger & no condition in flows/valid to load it in tests is enough to test it no longer breaks as it would fail all the other tests since it crashes the app at launch currently...

@brian-mulier-p brian-mulier-p force-pushed the fix/flow-triggers-without-condition branch from e0e30ab to 256eb52 Compare September 8, 2023 07:03
loicmathieu
loicmathieu reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Flow trigger without condition will never start any execution right? If so it may be a good idea to mandate a condition (but keep the code failsafe)

@brian-mulier-p brian-mulier-p force-pushed the fix/flow-triggers-without-condition branch from 256eb52 to 2d66243 Compare September 8, 2023 08:24
@brian-mulier-p
Copy link
Member Author

brian-mulier-p commented Sep 8, 2023 •
edited
Loading

It will always start (since no condition, it will start on every terminated (failed or success) flow)
There's a warning on it in the doc

loicmathieu
loicmathieu approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p force-pushed the fix/flow-triggers-without-condition branch from 2d66243 to a56cdc5 Compare September 8, 2023 08:42
@brian-mulier-p brian-mulier-p force-pushed the fix/flow-triggers-without-condition branch from a56cdc5 to 52575f9 Compare September 8, 2023 09:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@brian-mulier-p brian-mulier-p merged commit 7044a4c into develop Sep 8, 2023
@brian-mulier-p brian-mulier-p deleted the fix/flow-triggers-without-condition branch September 8, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@Skraye Skraye Awaiting requested review from Skraye

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Flows" trigger can't have null conditions
2 participants
@brian-mulier-p @loicmathieu