fix(core): don't retry a task if the execution is killed #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this will make the task not killing but ends with the "previous" state (failed), the execution will then be marked as failed and not killed at the moment, but if #1747 is merged the execution will correctly be marked as KILLED. Anyway, currently, without this , the exuction is also marked as FAILED but the attempts continue so this PR improve the current process by shortcirciting the attempt for killed execution.
|
Kudos, SonarCloud Quality Gate passed! |
brian-mulier-p
requested changes
Sep 11, 2023
| @@ -308,7 +308,8 @@ private WorkerTaskResult run(WorkerTask workerTask, Boolean cleanUp) throws Queu | |||
| WorkerTask finalWorkerTask = Failsafe | |||
| .with(AbstractRetry.<WorkerTask>retryPolicy(workerTask.getTask().getRetry()) | |||
| .handleResultIf(result -> result.getTaskRun().lastAttempt() != null && | |||
| Objects.requireNonNull(result.getTaskRun().lastAttempt()).getState().getCurrent() == State.Type.FAILED | |||
| result.getTaskRun().lastAttempt().getState().getCurrent() == State.Type.FAILED && | |||
There was a problem hiding this comment.
It lacks a test to cover it I think
There was a problem hiding this comment.
I can try to make one but as it's by nature racy the test might be flaky.
tchiotludo
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will make the task not killing but ends with the "previous" state (failed), the execution will then be marked as failed and not killed at the moment, but if #1747 is merged the execution will correctly be marked as KILLED. Anyway, currently, without this, the execution is also marked as FAILED, but the attempts continue so this PR improves the current process by short-circuiting the attempt for killed execution.