Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the environment name to the page title #2051

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Propagate the environment name to the page title #2051

merged 2 commits into from
Sep 26, 2023

Conversation

yuri1969
Copy link
Contributor

@yuri1969 yuri1969 commented Sep 6, 2023

It's useful to have the environment displayed in the title. For example, password manager auto-type or visual info in browser tabs.

@yuri1969 @tchiotludo
Propagate the environment name to the page title
b5ac4d8 
It's useful to have the environment displayed in the title.
For example, password manager auto-type or visual info in browser tabs.
@tchiotludo tchiotludo added the enhancement New feature or request label Sep 22, 2023
brian-mulier-p
brian-mulier-p requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex replace is currently not working on my setup, there's no "-" in the title. Maybe you have to check if present first then append if not or replace if it is ? 🤔

@yuri1969
Copy link
Contributor Author

The regex replace is currently not working on my setup, there's no "-" in the title. Maybe you have to check if present first then append if not or replace if it is ? 🤔

There was an issue with removing the suffix completely. That one should be fixed.

However, the regex should match the end of the title string in any case - with or without the dash.

brian-mulier-p
brian-mulier-p approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I think I had some build cache issue 👍
LGTM, thanks again :)

@brian-mulier-p brian-mulier-p merged commit b0459d8 into kestra-io:develop Sep 26, 2023
@yuri1969 yuri1969 deleted the title branch September 26, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
All issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuri1969 @brian-mulier-p @tchiotludo