Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/deprecate-listeners #2020

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix/deprecate-listeners #2020

merged 1 commit into from
Sep 5, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1409

@brian-mulier-p brian-mulier-p self-assigned this Sep 4, 2023
@brian-mulier-p brian-mulier-p mentioned this pull request Sep 4, 2023
Closed
loicmathieu
loicmathieu requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Listener class itself must be deprecated, I think.

@brian-mulier-p
Copy link
Member Author

The Listener class itself must be deprecated, I think.

It looks ugly to do so 🤔 moreover aren't we planning to keep them for SLA part for eg. ?
image

@anna-geller
Copy link
Member

anna-geller commented Sep 4, 2023 •
edited
Loading

Listeners have to be deprecated for several reasons - listing those I'm aware of:

  1. they require extra workarounds in the codebase
  2. they are redundant -- there is nothing in listeners that you couldn't do with Flow triggers
  3. one more concept that users need to learn even though they don't have to if they already know Flow triggers

@brian-mulier-p
Copy link
Member Author

I can do it but rn it will look ugly on the warning part but as you wish

@anna-geller anna-geller mentioned this pull request Sep 4, 2023
Open
@brian-mulier-p brian-mulier-p force-pushed the fix/deprecate-listeners branch from e6aa237 to 4d6c4b6 Compare September 5, 2023 08:29
@loicmathieu
Copy link
Member

We discussed this this morning and decided to only deprecate the property to avoid too many warnings on the UI.

loicmathieu
loicmathieu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p force-pushed the fix/deprecate-listeners branch from 4d6c4b6 to 8777768 Compare September 5, 2023 11:29
@brian-mulier-p brian-mulier-p merged commit 29410df into develop Sep 5, 2023
@brian-mulier-p brian-mulier-p deleted the fix/deprecate-listeners branch September 5, 2023 12:09
@anna-geller anna-geller mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate listeners in favor of triggers
3 participants
@brian-mulier-p @anna-geller @loicmathieu