Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): even better wording in the guided tour #1964

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

anna-geller
Copy link
Member

Still some things can be further enhanced

also @brian-mulier-p can you help me fix this issue? the window disappears to the bottom left corner on step 11 and step 12 after saving the flow in step 10

image

@brian-mulier-p
Copy link
Member

This is a long known bug which @Skraye was aware of, don't know if he found the reason but I can check it next week (sometimes there is no issue so we might need to find the 100% reproducer)

@tchiotludo tchiotludo merged commit a5fdd06 into develop Aug 28, 2023
@tchiotludo tchiotludo deleted the fix/wording-guided-tour branch August 28, 2023 07:01
@Skraye
Copy link
Member

Skraye commented Aug 28, 2023

@brian-mulier-p The issue is that the modal pop before content is loaded
I think what needs to be done is when triggering next (or clicking the save button) to save the flow, include a custom param in the action to tell that we're in the guided tour, and it has to trigger the next step once the action is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants