Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/multiple-conditions-service #1950

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat/multiple-conditions-service #1950

merged 3 commits into from
Aug 28, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1917

@brian-mulier-p brian-mulier-p self-assigned this Aug 24, 2023
@brian-mulier-p brian-mulier-p force-pushed the feat/multiple-conditions-service branch 6 times, most recently from 6a97a7d to 631c1f3 Compare August 25, 2023 13:12
@brian-mulier-p brian-mulier-p force-pushed the feat/multiple-conditions-service branch 2 times, most recently from 086df0e to 5d9d18d Compare August 25, 2023 15:46
@tchiotludo tchiotludo requested a review from loicmathieu August 28, 2023 07:07
loicmathieu
loicmathieu requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove the changes to package-lock.json as they are unrelated

core/src/main/java/io/kestra/core/services/AbstractFlowTriggerService.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/services/AbstractFlowTriggerService.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/services/FlowService.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/services/FlowService.java Show resolved Hide resolved
core/src/main/java/io/kestra/core/services/AbstractFlowTriggerService.java Outdated Show resolved Hide resolved
@brian-mulier-p brian-mulier-p force-pushed the feat/multiple-conditions-service branch from 5d9d18d to b82a0e2 Compare August 28, 2023 07:54
@brian-mulier-p
fix(core): multiple conditions are now working properly for "double f…
974729b 
…low in success within window" example + exported all multiple conditions related evaluation / save to a service

closes #1917
@brian-mulier-p brian-mulier-p force-pushed the feat/multiple-conditions-service branch from b82a0e2 to 974729b Compare August 28, 2023 07:55
@brian-mulier-p brian-mulier-p force-pushed the feat/multiple-conditions-service branch from 499e4ac to 28fb2de Compare August 28, 2023 09:37
@brian-mulier-p brian-mulier-p merged commit 5c61c4b into develop Aug 28, 2023
@brian-mulier-p brian-mulier-p deleted the feat/multiple-conditions-service branch August 28, 2023 12:07
brian-mulier-p added a commit that referenced this pull request Aug 28, 2023
@brian-mulier-p
feat(core): multiple-conditions-service (#1950)
8d56de8 
closes #1917
brian-mulier-p added a commit that referenced this pull request Aug 28, 2023
@brian-mulier-p
feat(core): multiple conditions service (#1950)
ceebe42 
closes #1917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple condition on flow trigger does not handle consistently the flow state
2 participants
@brian-mulier-p @loicmathieu