Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Kestra environments #1875

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Label Kestra environments #1875

merged 2 commits into from
Aug 18, 2023

Conversation

yuri1969
Copy link
Contributor

Added env name + color settings to set local user-specific labels.

close #1483

Added env name + color settings to set local user-specific labels.
@anna-geller
Copy link
Member

anna-geller commented Aug 10, 2023

Thank you! ❤️

@tchiotludo
Copy link
Member

@yuri1969 maybe it could be better to have as a configuration variable?
I don't think people will want to have a different value for the same instance?
WDYT?

@yuri1969
Copy link
Contributor Author

@tchiotludo At first, I thought the same - to have the cluster identify itself under a name (a config property => /api/v1/configs). Then I realized this was a similar situation to a GUI DB client (think of DBeaver) where you name/label/colorize your connections locally. So it is set locally.

Would there be any other use of the name on the backend/API?

Personally, I have no preference of either choice.

@yuri1969
Copy link
Contributor Author

...and now I've discovered the possibility of having a (quirky) environment label is already present as kestra.webserver.html-head.

@anna-geller
Copy link
Member

There seems to be a decision bottleneck here - @tchiotludo can you check how can we move forward to get this merged?

@tchiotludo
Copy link
Member

I didn't see other needs than the environments for this one.

I think the best can be both!

  • a global configuration by default
  • a setting that allow people to change it based on their needs ?
    WDTY ?

@tchiotludo tchiotludo merged commit 3cb3f9d into kestra-io:develop Aug 18, 2023
@tchiotludo
Copy link
Member

I've added the global setting and made some adjust, thanks for the contributions 👏

@yuri1969 yuri1969 deleted the env branch August 19, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a custom UI color and label helping to distinguish between development and production environments
3 participants