Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reindex all flows command #1846

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

loicmathieu
Copy link
Member

No description provided.

Copy link
Member

@tchiotludo tchiotludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer en ReindexCommand with option like this one

@loicmathieu
Copy link
Member Author

I found it easier this way as you usually only reindex one type of data.

And this is an option (for the user); it's just as all commands will use a different repository I thought it would be better to have one command by object type.

But if you prefer I can have a single command that takes the object type as option.

@tchiotludo
Copy link
Member

I prefer to have some consistency and to avoid too many commands

@loicmathieu loicmathieu force-pushed the feat/allow-reindex-all-flows branch from c3bd5c8 to a55a1f4 Compare August 4, 2023 15:47
@loicmathieu
Copy link
Member Author

I move to a single command with a --type option to give the type of records to reindex.

@tchiotludo tchiotludo merged commit be58d0e into develop Aug 8, 2023
@tchiotludo tchiotludo deleted the feat/allow-reindex-all-flows branch August 8, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants