-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/date-format-settings #1843
Conversation
@Ben8t @anna-geller Do you think every date should be parsed? For example, logs dates? |
maybe not logs dates (as we usually need granularity here), but otherwise I think yes |
I think date should be displayed in the browser timezone (so no +02:00). |
@Skraye it seems nice if logs stay in a standard format as they are commonly streamed/exported to other systems. I like UTC and explicit notation when something is in a specific timezone, so this LGTM 👍 |
I appreciate the screenshots in the UI PR @brian-mulier-p - so helpful! |
@anna-geller this PR didn't changed the format on the database nor the API results, so if someone use a tool to extract logs it will still be in the same format (which should be ISO but I didn't check). |
So is it LGTM after all ? 😆 |
Or maybe I should add the timezone override and we're good ? |
See if the timezone can be done quickly. |
70db7ed
to
118bdf4
Compare
I intentionally did not change the logs date format as I feel like this date should be fully displayed in all case
closes #1166