Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/date-format-settings #1843

Merged
merged 3 commits into from
Aug 9, 2023
Merged

feat/date-format-settings #1843

merged 3 commits into from
Aug 9, 2023

Conversation

brian-mulier-p
Copy link
Member

I intentionally did not change the logs date format as I feel like this date should be fully displayed in all case

closes #1166

@brian-mulier-p brian-mulier-p requested a review from Skraye August 2, 2023 08:03
@brian-mulier-p brian-mulier-p self-assigned this Aug 2, 2023
@brian-mulier-p
Copy link
Member Author

image
image

@Skraye
Copy link
Member

Skraye commented Aug 2, 2023

@Ben8t @anna-geller Do you think every date should be parsed? For example, logs dates?

@Ben8t
Copy link
Member

Ben8t commented Aug 2, 2023

@Ben8t @anna-geller Do you think every date should be parsed? For example, logs dates?

maybe not logs dates (as we usually need granularity here), but otherwise I think yes

@loicmathieu
Copy link
Member

I think date should be displayed in the browser timezone (so no +02:00).
And we also need to have a way to override the timezone.

@anna-geller
Copy link
Member

@Skraye it seems nice if logs stay in a standard format as they are commonly streamed/exported to other systems. I like UTC and explicit notation when something is in a specific timezone, so this LGTM 👍

@anna-geller
Copy link
Member

I appreciate the screenshots in the UI PR @brian-mulier-p - so helpful!

@loicmathieu
Copy link
Member

@anna-geller this PR didn't changed the format on the database nor the API results, so if someone use a tool to extract logs it will still be in the same format (which should be ISO but I didn't check).

@brian-mulier-p
Copy link
Member Author

So is it LGTM after all ? 😆

@brian-mulier-p
Copy link
Member Author

Or maybe I should add the timezone override and we're good ?

@Skraye
Copy link
Member

Skraye commented Aug 4, 2023

See if the timezone can be done quickly.
However I need to test it first

@brian-mulier-p brian-mulier-p force-pushed the feat/date-format-settings branch from 70db7ed to 118bdf4 Compare August 7, 2023 17:52
@tchiotludo tchiotludo merged commit a037a6f into develop Aug 9, 2023
@tchiotludo tchiotludo deleted the feat/date-format-settings branch August 9, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a date format setting
6 participants