Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/working dir validation #1838

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix/working dir validation #1838

merged 2 commits into from
Aug 1, 2023

Conversation

loicmathieu
Copy link
Member

No description provided.

Skraye
Skraye approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but missed a test for this use case

@loicmathieu loicmathieu force-pushed the fix/working-dir-validation branch from 85ef96f to 6b31a74 Compare August 1, 2023 07:45
@loicmathieu
Copy link
Member Author

@Skraye I added one.

@loicmathieu loicmathieu merged commit e4678a5 into develop Aug 1, 2023
@loicmathieu loicmathieu deleted the fix/working-dir-validation branch August 1, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @Skraye