Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/show-conditions-in-triggers-doc #1836

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix/show-conditions-in-triggers-doc #1836

merged 1 commit into from
Jul 31, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1704

@brian-mulier-p brian-mulier-p self-assigned this Jul 31, 2023
loicmathieu
loicmathieu approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with this we will be able to choose which base property we display if we choose to display other properties

@brian-mulier-p
fix(doc-gen): now also displaying properties with @PluginProperty ins…
b90eb0c 
…ide bases in json schema (including conditions)

closes #1704
@brian-mulier-p brian-mulier-p force-pushed the fix/show-conditions-in-triggers-doc branch from 783bbb6 to b90eb0c Compare July 31, 2023 12:01
@brian-mulier-p brian-mulier-p merged commit 96551f4 into develop Jul 31, 2023
@brian-mulier-p brian-mulier-p deleted the fix/show-conditions-in-triggers-doc branch July 31, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Triggers do not display conditions attribute in doc
2 participants
@brian-mulier-p @loicmathieu