Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to cache contents inside the working directory #1822

Merged
merged 1 commit into from
Jul 28, 2023
Merged

feat: allow to cache contents inside the working directory #1822

merged 1 commit into from
Jul 28, 2023

Conversation

loicmathieu
Copy link
Member

close #1275

@loicmathieu loicmathieu force-pushed the feat/workingdirectory-cache branch from 50a8fe1 to ba1c02c Compare July 28, 2023 08:37
@loicmathieu loicmathieu marked this pull request as ready for review July 28, 2023 08:37
@loicmathieu loicmathieu force-pushed the feat/workingdirectory-cache branch 2 times, most recently from 16850b8 to c905f1b Compare July 28, 2023 09:05
brian-mulier-p
brian-mulier-p approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some slight changes

core/src/main/java/io/kestra/core/storages/StorageInterface.java Show resolved Hide resolved
core/src/main/java/io/kestra/core/storages/StorageInterface.java Show resolved Hide resolved
@loicmathieu loicmathieu force-pushed the feat/workingdirectory-cache branch from c905f1b to 377946c Compare July 28, 2023 09:18
@loicmathieu loicmathieu merged commit bde5ff6 into develop Jul 28, 2023
@loicmathieu loicmathieu deleted the feat/workingdirectory-cache branch July 28, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching file dependancies in WorkingDir
2 participants
@loicmathieu @brian-mulier-p