Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add a method to help getting a file extension #1805

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat(core): add a method to help getting a file extension #1805

merged 1 commit into from
Jul 25, 2023

Conversation

loicmathieu
Copy link
Member

This will be used in tasks that download a file and want to preserve the extension.

Skraye
Skraye approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit dd68b56 into develop Jul 25, 2023
@loicmathieu loicmathieu deleted the feat/file-extension-helper branch July 25, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @Skraye