Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/triggers-administration #1795

Merged
merged 2 commits into from
Jul 24, 2023
Merged

feat/triggers-administration #1795

merged 2 commits into from
Jul 24, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1777

@brian-mulier-p brian-mulier-p self-assigned this Jul 21, 2023
@brian-mulier-p brian-mulier-p force-pushed the feat/triggers-administration branch from a376f10 to 833054e Compare July 24, 2023 07:49
@brian-mulier-p brian-mulier-p force-pushed the feat/triggers-administration branch 4 times, most recently from 56a3aa1 to ffbc352 Compare July 24, 2023 09:24
loicmathieu
loicmathieu approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think th sortMapping is useless, at least as it's not overridden you can just use the identity function directly inside the controller.

However, it's good to me.

webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java Show resolved Hide resolved
@brian-mulier-p
Copy link
Member Author

sortMapping is still overriden for JDBC Repositories as they need to convert camelCase to column names which are in snake_case as said above

@brian-mulier-p brian-mulier-p force-pushed the feat/triggers-administration branch 2 times, most recently from a590125 to a97ccd4 Compare July 24, 2023 14:33
loicmathieu
loicmathieu approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p force-pushed the feat/triggers-administration branch from a97ccd4 to e5723c2 Compare July 24, 2023 14:46
@brian-mulier-p brian-mulier-p merged commit 426814d into develop Jul 24, 2023
@brian-mulier-p brian-mulier-p deleted the feat/triggers-administration branch July 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@Skraye Skraye Awaiting requested review from Skraye

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Administration panel -> Triggers view
2 participants
@brian-mulier-p @loicmathieu