Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): Allow to change fontSize & fontFamily in editor from Settings #1787

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Jul 20, 2023

close #1218
close #1654

@Skraye Skraye requested a review from brian-mulier-p July 20, 2023 13:44
@Skraye Skraye self-assigned this Jul 20, 2023
@loicmathieu
Copy link
Member

On hour late for my demo but still happy to see this done ;)

@loicmathieu
Copy link
Member

Small bug when you select Times
image

Also the very big input for the size is a bit strange, maybe set it to a smaller size

@Skraye Skraye requested a review from loicmathieu July 21, 2023 07:31
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skraye Skraye merged commit 226e971 into develop Jul 21, 2023
@Skraye Skraye deleted the feat/editor-improvements branch July 21, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom fonts for foreign language Accessibility - Users can't change editor font size
2 participants