Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): serialization inclusion is a single property not a list #1766

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix(core): serialization inclusion is a single property not a list #1766

merged 1 commit into from
Jul 21, 2023

Conversation

loicmathieu
Copy link
Member

So setting it two times will override the previous one.

@loicmathieu
fix(core): serialization inclusion is a single property not a list
2611231 
So setting it two times will override the previous one.
@loicmathieu loicmathieu requested a review from Skraye July 18, 2023 15:35
brian-mulier-p
brian-mulier-p approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit 48edf70 into develop Jul 21, 2023
@loicmathieu loicmathieu deleted the fix/json-inclusion branch July 21, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

@Skraye Skraye Awaiting requested review from Skraye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @brian-mulier-p