Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/labels #1743

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Fix/labels #1743

merged 3 commits into from
Jul 13, 2023

Conversation

loicmathieu
Copy link
Member

No description provided.

@loicmathieu loicmathieu marked this pull request as ready for review July 13, 2023 10:29
@loicmathieu loicmathieu requested a review from Skraye July 13, 2023 10:29
brian-mulier-p
brian-mulier-p requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight adjustments but looks good otherwise

core/src/main/java/io/kestra/core/models/Label.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/serializers/ListOrMapOfLabelSerializer.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/utils/LabelUtils.java Show resolved Hide resolved
core/src/main/java/io/kestra/core/serializers/ListOrMapOfLabelDeserializer.java Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/serializers/ListOrMapOfLabelDeserializer.java Outdated Show resolved Hide resolved
ui/src/components/layout/Labels.vue Outdated Show resolved Hide resolved
ui/src/components/layout/Labels.vue Outdated Show resolved Hide resolved
brian-mulier-p
brian-mulier-p approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit 44ecc27 into develop Jul 13, 2023
@loicmathieu loicmathieu deleted the fix/labels branch July 13, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

@Skraye Skraye Awaiting requested review from Skraye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @brian-mulier-p