Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto refresh button is not a switch #1802

Closed
brian-mulier-p opened this issue Jul 24, 2023 · 0 comments · Fixed by #1803
Closed

Auto refresh button is not a switch #1802

brian-mulier-p opened this issue Jul 24, 2023 · 0 comments · Fixed by #1803
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@brian-mulier-p
Copy link
Member

Expected Behavior

No response

Actual Behaviour

At first it looks like the auto refresh button is a switch cause when we click on it the background color stays purple. However it is only due to button keeping focus effect afterwards. If you click anywhere else on the page then you have no feedback of whether or not the auto refresh is active.

Also, it is even worst when the local storage kicks in as it retrieves the previous state from the local storage. However when we come on a page with the auto refresh being active due to local storage, since we didn't click on it we don't have the "on focus" effect, which make the auto refresh looking disabled while it is active.

I think we should use the checkbox element instead.

Steps To Reproduce

No response

Environment Information

  • Kestra Version: 0.11.0-SNAPSHOT
  • Operating System (OS / Docker / Kubernetes):
  • Java Version (If not docker):

Example flow

No response

@brian-mulier-p brian-mulier-p added bug Something isn't working enhancement New feature or request labels Jul 24, 2023
@github-project-automation github-project-automation bot moved this to Backlog in All issues Jul 24, 2023
@brian-mulier-p brian-mulier-p moved this from Backlog to Ready in All issues Jul 24, 2023
@brian-mulier-p brian-mulier-p moved this from Ready to Review in All issues Jul 24, 2023
@brian-mulier-p brian-mulier-p self-assigned this Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in All issues Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant