Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #7

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Nov 14, 2019

This PR removes the dependencies on string.prototype.trim and for-each.

for-each contains utilities to iterate over strings, arrays, and objects, and contains checks to handle lots of corner cases, but this package doesn't need any of that because it only iterates over one simple array.

string.prototype.trim pulls in 13 dependencies. These add up to 16KB minified/4KB gzipped. The one-line function I replaced it with is equivalent to the original trim package removed in #6.

@kesla
Copy link
Owner

kesla commented Nov 14, 2019

Thank you!!

@kesla kesla merged commit 9072580 into kesla:master Nov 14, 2019
@kesla kesla mentioned this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants