-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api.main: perform authorization for GET '/users' #430
Conversation
Only allow authorized users to get existing users' details to protect user's personal information. Signed-off-by: Jeny Sadadia <[email protected]>
96d79cb
to
849f178
Compare
Verified manually using curl:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! :)
But, this should only be returning public information. I think it's a step backwards, being able to find user information publicly makes sense and all public web services do this. Also, if all it takes is a user account then I would argue it's a false sense of security as it's not preventing any personal user data from being shared with other individuals. |
Email is not public information, at least. I think it is better to move this discussion to Slack. |
I can see your email address on your public profile here ;) https://github.com/nuclearcat |
Yes, that intentional and github explicitly shows it will be published on github profile page. |
Yes, I know :) As discussed on Slack now. Maybe a GitHub issue or discussion about how to manage users in general would be good actually. |
Only allow authorized users to get existing users' details to protect user's personal information.