Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #19571
Most tests in
keras/src/layers
are passing. This included updated and implemented ops functions (especially inrandom
,image
, andnumpy
)layers/preprocessing/image_preprocessing/random_crop.py RandomCrop.get_random_transformation()
okay?mlx.arrays
(incl scalar values)mlx.random.py beta()
might need adjusting how it checks ifshape
is broadcastable withalpha
andbeta
Couple mlx notes, these be will fixed in their next patch release:
mlx.core.einsum
was failing with ellipsis::-1
(this affected transpose convolutions), it's currently being handled with a reversed index array andmlx.core.take
(Sorry this got a bit large! I wanted to merge back to the mlx branch before continuing)