Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_erasing layer #20798

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Add random_erasing layer #20798

merged 5 commits into from
Jan 24, 2025

Conversation

shashaka
Copy link
Contributor

@shashaka shashaka commented Jan 23, 2025

I have implemented the RandomErasing image processing feature. Please let me know if any further corrections or improvements are required.

here is my gist

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (5df8fb9) to head (fce9c0c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...reprocessing/image_preprocessing/random_erasing.py 82.92% 13 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #20798    +/-   ##
========================================
  Coverage   82.01%   82.01%            
========================================
  Files         557      558     +1     
  Lines       52014    52145   +131     
  Branches     8037     8054    +17     
========================================
+ Hits        42657    42769   +112     
- Misses       7403     7415    +12     
- Partials     1954     1961     +7     
Flag Coverage Δ
keras 81.83% <81.74%> (+<0.01%) ⬆️
keras-jax 64.27% <77.77%> (+0.05%) ⬆️
keras-numpy 59.00% <72.22%> (+0.04%) ⬆️
keras-openvino 29.86% <17.46%> (-0.04%) ⬇️
keras-tensorflow 64.82% <77.77%> (+0.03%) ⬆️
keras-torch 64.20% <77.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for the PR!

@shashaka
Copy link
Contributor Author

@fchollet
I have updated the source code based on your guidance. Please let me know if any further corrections are needed.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution! 👍

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 24, 2025
@fchollet fchollet merged commit 3de2270 into keras-team:master Jan 24, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 24, 2025
@shashaka shashaka deleted the random_erasing branch January 24, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants