Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#20144] updated documentation for DenseNet, Xception, and ResNet #20223

Merged

Conversation

joehiggi1758
Copy link
Contributor

@joehiggi1758 joehiggi1758 commented Sep 6, 2024

Updated documentation for DenseNet, Xception and ResNet to mirror MobileNet's classes callout for default to 1000.

…ResNet to reflect 1000 as default classes value
Copy link

google-cla bot commented Sep 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (efec341) to head (fd1d5a1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20223      +/-   ##
==========================================
+ Coverage   79.37%   82.12%   +2.74%     
==========================================
  Files         501      501              
  Lines       47440    47440              
  Branches     8711     8711              
==========================================
+ Hits        37655    38958    +1303     
+ Misses       8022     6570    -1452     
- Partials     1763     1912     +149     
Flag Coverage Δ
keras 81.97% <ø> (+2.75%) ⬆️
keras-jax 65.27% <ø> (+2.75%) ⬆️
keras-numpy 57.84% <ø> (+0.14%) ⬆️
keras-tensorflow 66.65% <ø> (+2.75%) ⬆️
keras-torch 65.30% <ø> (+2.74%) ⬆️
keras.applications 80.40% <ø> (?)
keras.applications-jax 80.40% <ø> (?)
keras.applications-numpy 22.95% <ø> (?)
keras.applications-tensorflow 80.40% <ø> (?)
keras.applications-torch 80.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Sep 6, 2024
@fchollet fchollet merged commit cb6ece3 into keras-team:master Sep 6, 2024
7 of 8 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Sep 6, 2024
@joehiggi1758
Copy link
Contributor Author

@fchollet thank you for the opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants