Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/applications] Standardise docstring usage of "Default to" #17954

Merged

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

…ras/applications/efficientnet_v2.py,keras/applications/imagenet_utils.py,keras/applications/inception_v3.py,keras/applications/mobilenet.py,keras/applications/mobilenet_v3.py,keras/applications/regnet.py,keras/applications/resnet_rs.py] Standardise docstring usage of "Default to"
@gbaned gbaned requested a review from haifeng-jin April 13, 2023 05:48
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
@haifeng-jin haifeng-jin requested review from qlzh727 and removed request for haifeng-jin April 22, 2023 22:49
@haifeng-jin
Copy link
Contributor

Need @qlzh727 review the "{mode}" thing for this PR.

@SamuelMarks
Copy link
Contributor Author

@haifeng-jin Fixed: fastmod -Fepy '{mode}.' '

@mihirparadkar mihirparadkar removed the keras-team-review-pending Pending review by a Keras team member. label Apr 26, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 27, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 28, 2023
…lt to"

Imported from GitHub PR #17954

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
f4445f1 by Samuel Marks <[email protected]>:

[keras/applications/convnext.py,keras/applications/efficientnet.py,keras/applications/efficientnet_v2.py,keras/applications/imagenet_utils.py,keras/applications/inception_v3.py,keras/applications/mobilenet.py,keras/applications/mobilenet_v3.py,keras/applications/regnet.py,keras/applications/resnet_rs.py] Standardise docstring usage of "Default to"

--
5879670 by Samuel Marks <[email protected]>:

[keras/applications] Remove  as these docstrings aren't interpolated

Merging this change closes #17954

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17954 from SamuelMarks:keras.applications-defaults-to 5879670
PiperOrigin-RevId: 527920188
@gbaned gbaned requested a review from qlzh727 May 25, 2023 16:02
copybara-service bot pushed a commit that referenced this pull request May 25, 2023
…lt to"

Imported from GitHub PR #17954

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
f4445f1 by Samuel Marks <[email protected]>:

[keras/applications/convnext.py,keras/applications/efficientnet.py,keras/applications/efficientnet_v2.py,keras/applications/imagenet_utils.py,keras/applications/inception_v3.py,keras/applications/mobilenet.py,keras/applications/mobilenet_v3.py,keras/applications/regnet.py,keras/applications/resnet_rs.py] Standardise docstring usage of "Default to"

--
5879670 by Samuel Marks <[email protected]>:

[keras/applications] Remove  as these docstrings aren't interpolated

Merging this change closes #17954

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17954 from SamuelMarks:keras.applications-defaults-to 5879670
PiperOrigin-RevId: 535286449
@copybara-service copybara-service bot merged commit a8d4a7f into keras-team:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ready to pull Ready to be merged into the codebase size:M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants