Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix sequence padding documentation #279

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Conversation

joshzwiebel
Copy link
Contributor

The default parameter for padding is pre. The docs reflect the change

Summary

Related Issues

PR Overview

  • [ n] This PR requires new unit tests [y/n] (make sure tests are included)
  • [ n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y ] This PR is backwards compatible [y/n]
  • [n ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

The default parameter for padding is pre. The docs reflect the change
@joshzwiebel joshzwiebel requested a review from fchollet February 13, 2020 03:15
@joshzwiebel joshzwiebel requested a review from Dref360 February 14, 2020 01:16
@Dref360
Copy link
Contributor

Dref360 commented Feb 14, 2020

You need to remove dist: trusty in travis.yml

@joshzwiebel
Copy link
Contributor Author

You need to remove dist: trusty in travis.yml

I can do that. What does that line do?

@Dref360
Copy link
Contributor

Dref360 commented Feb 14, 2020

It forces the ubuntu version to be trusty, but we want the latest.
I mad ea PR myself, but I cannot merge it myself, so if you could do it that would be awesome!

@joshzwiebel
Copy link
Contributor Author

Sure. I will do that today. I am trying to be more involved in open source, other than the good first issues page here is there anywhere else that specifically needs work?

@Dref360
Copy link
Contributor

Dref360 commented Feb 14, 2020

At the last Keras board meeting, it was voted to deprecate Keras-preprocessing
in favor of a new keras module that would be more composable. (see keras-team/governance#10)

So contributing to this new API would be best. (here: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/python/keras/layers/preprocessing)

The issue right now is that Keras is still tightly integrated with TF, but it should be split in the future! (see tensorflow/community#202)

This will make contributing easier because the CI will be faster.

@joshzwiebel
Copy link
Contributor Author

Thanks for your response! A standalone Keras repo would be great because I definitely feel more comfortable contributing to Keras than most of TensorFlow and it is easy to get lost or have difficulty navigating such a large repository. I will migrate future contributions to the TensorFlow repo

@Dref360 Dref360 merged commit f80d4a1 into keras-team:master Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants