Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "tokens" -> "token_ids" #1152

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Update "tokens" -> "token_ids" #1152

merged 1 commit into from
Dec 10, 2022

Conversation

jbischof
Copy link
Contributor

Output dictionary names changed in keras-team/keras-hub#327, but guide never updated

TESTED=ran guide locally

MarkDaoust
MarkDaoust requested changes Dec 10, 2022
View reviewed changes
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems uncontroversal.

Please run:

cd scripts
python autogen.py add_guide/transformer_pretraining

To update downstream files.

@mattdangerw
Copy link
Member

@jbischof actually we should be careful here. I believe that change is only on our master branch, and we want to keep this guide in a state that will work with !pip install keras-nlp until we do our next release.

I opened keras-team/keras-hub#508 to track issue like this.

We should make sure not to actually land this PR until we are pushing out our new pypi release.

fchollet
fchollet approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit fb633da into keras-team:master Dec 10, 2022
mattdangerw added a commit that referenced this pull request Dec 12, 2022
@mattdangerw
Revert "Update "tokens" -> "token_ids" (#1152)"
2a95d61 
This reverts commit fb633da.
@mattdangerw mattdangerw mentioned this pull request Dec 12, 2022
Merged
MarkDaoust pushed a commit that referenced this pull request Dec 12, 2022
@mattdangerw
Revert "Update "tokens" -> "token_ids" (#1152)" (#1155)
b56f87a 
This reverts commit fb633da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust requested changes

@fchollet fchollet fchollet approved these changes

@ianstenbit ianstenbit ianstenbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbischof @mattdangerw @fchollet @MarkDaoust @ianstenbit