Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpt2, t5 and fnet under mixed precision #958

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

mattdangerw
Copy link
Member

Also add a testing mode, --mixed_precision for this, though it does not fully pass yet due to saving and other output errors.

Also add a testing mode for mixed precision, though it does not fully
pass yet due to saving and other output errors.
@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw
Copy link
Member Author

/gcbrun

@chenmoneygithub
Copy link
Contributor

@mattdangerw I am very confused about the GCP testing failure, it complains about the diff between model outputs and loaded model outputs:

Step #5 - "create-job": E       not close lhs = [-0.02194774  0.03975677  0.0241155   0.02628191 -0.01379672 -0.01609562
Step #5 - "create-job": E         0.00820724 -0.02046685  0.02078998  0.01787513]
Step #5 - "create-job": E       not close rhs = [ 0.02194796 -0.03975716 -0.02411573 -0.02628217  0.01379685  0.01609577
Step #5 - "create-job": E        -0.00820732  0.02046705 -0.02079018 -0.0178753 ]
Step #5 - "create-job": E       not close dif = [0.0438957  0.07951393 0.04823123 0.05256408 0.02759357 0.03219139
Step #5 - "create-job": E        0.01641455 0.0409339  0.04158016 0.03575043]
Step #5 - "create-job": E       not close tol = [0.01021948 0.01039757 0.01024116 0.01026282 0.01013797 0.01016096
Step #5 - "create-job": E        0.01008207 0.01020467 0.0102079  0.01017875]

@mattdangerw
Copy link
Member Author

mattdangerw commented Apr 4, 2023

@chenmoneygithub this is a recent and unrelated flake I believe. Happened on #856 as well.

Opened #960

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw mattdangerw merged commit b0c457e into keras-team:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants