Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Whisper docstrings for progressive disclosure of complexity #903

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

susnato
Copy link
Contributor

@susnato susnato commented Mar 22, 2023

Partially fixes: #867

  • Make sure to update any "custom vocabulary" examples to match the model actual vocabulary type and special token requirements (varies per model).
  • Test out all docstring snippets!
    Gist of all docstring snippets.
  • Make sure to follow our code style guidelines re indentation etc.

@mattdangerw

@mattdangerw
Copy link
Member

TY!

@mattdangerw mattdangerw merged commit fc75668 into keras-team:master Mar 22, 2023
shivance pushed a commit to shivance/keras-nlp that referenced this pull request Mar 26, 2023
shivance pushed a commit to shivance/keras-nlp that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework model docstrings for progressive disclosure of complexity
2 participants