Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding the tests for xlm_roberta #885

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

susnato
Copy link
Contributor

@susnato susnato commented Mar 20, 2023

What does this PR do?
This PR modifies tests as described in issue for xlm-roberta.

Results
before - 38 passed, 32 skipped in 91.88s
after - 31 passed, 36 skipped in 29.51s
3.11 times speedup(on my local machine)

@mattdangerw @chenmoneygithub

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This lgtm!

@mattdangerw mattdangerw merged commit 1f46731 into keras-team:master Mar 21, 2023
shivance pushed a commit to shivance/keras-nlp that referenced this pull request Mar 26, 2023
* tests modified for xlm_roberta

* nits
shivance pushed a commit to shivance/keras-nlp that referenced this pull request Mar 26, 2023
* tests modified for xlm_roberta

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants