-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added model card links for all pretrained models. #795
Changes from 4 commits
ddb6f61
c339df8
2e2fed8
cb647c9
991f938
009df13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ | |
"params": 66362880, | ||
"official_name": "DistilBERT", | ||
"path": "distil_bert", | ||
"model_card": "https://huggingface.co/distilbert-base-uncased", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of linking this, let's link the model card explicitly, So, in this case, https://huggingface.co/distilbert-base-uncased#distilbert-base-model-uncased. Same for other DistilBERT presets. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm ok with the main link actually. What is here is what you get when you click the model card tab on huggingface. (and i would somewhat suspect that anchor link might change down the link anyway) |
||
}, | ||
"config": { | ||
"vocabulary_size": 30522, | ||
|
@@ -52,6 +53,7 @@ | |
"params": 65190912, | ||
"official_name": "DistilBERT", | ||
"path": "distil_bert", | ||
"model_card": "https://huggingface.co/distilbert-base-cased", | ||
}, | ||
"config": { | ||
"vocabulary_size": 28996, | ||
|
@@ -78,6 +80,7 @@ | |
"params": 134734080, | ||
"official_name": "DistilBERT", | ||
"path": "distil_bert", | ||
"model_card": "https://huggingface.co/distilbert-base-multilingual-cased", | ||
}, | ||
"config": { | ||
"vocabulary_size": 119547, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a lot of code delta unrelated to the change we want to make in this PR. We should avoid making such changes. Make only those changes which are necessary for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rearranged dictionary orders so that metadata comes first in order to make it consistent with other presets, there is not much change apart from that.