-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fenced Doc-String #782 #785
Conversation
Thanks, @atharvapurdue! The reason why it's throwing an error is because the default value of
to values less than 4. Just change it to something like |
Yes! @abheesht17. I thought so, but wasn't sure. I will make the necessary changes. Thank you! |
change segment_ids value to default
Done ! @abheesht17 , Thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor comments.
@@ -114,6 +114,9 @@ def test_fenced_docstrings(): | |||
"keras_nlp.models.xlm_roberta.xlm_roberta_preprocessor", | |||
"keras_nlp.models.f_net.f_net_preprocessor", | |||
"keras_nlp.models.f_net.f_net_tokenizer", | |||
"keras_nlp.tokenizers.byte_pair_tokenizer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these three additions should be in the "base classes" block a few lines up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the required changes @mattdangerw. Please have a look
minor changes
Thank you! Works great! |
Following changes were made in Doc-String Examples -
The number of failed examples has gone down from 5 to 1, however I am getting 1 error in
File "/content/keras-nlp/keras-nlp/keras-nlp/keras_nlp/models/f_net/f_net_masked_lm.py", line 73, in keras_nlp.models.f_net.f_net_masked_lm.FNetMaskedLM
-Node: 'f_net_masked_lm_1/f_net_backbone_3/segment_embedding/embedding_lookup' indices[0,3] = 4 is not in [0, 4) [[{{node f_net_masked_lm_1/f_net_backbone_3/segment_embedding/embedding_lookup}}]] [Op:__inference_train_function_458156]
Might need help from @abheesht17 , or any other developer who can assist.
Thanks!
Fixes keras-team/keras-nlp #782