Pass Correct LayerNorm Epsilon value to TransformerEncoder in Backbones #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Could you please change the description to "Resolves #728" (without the word "issue")? That way, GitHub automatically marks this PR as the one which will close the mentioned issue. |
TheAthleticCoder
changed the title
TheAthleticCoder
changed the title
|
@mattdangerw A gentle reminder regarding the commit |
|
@TheAthleticCoder thanks! This looks good, but would it be possible to drop a comment here with links to where you found these constants? Would be a useful reference anyway. |
|
@mattdangerw The values of the constants were already there in the model files (model_backbone.py). I used those pre-existing constants and passed them into the main model architecture. |
|
Ah got it! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #728