Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default compilation for BERT/RoBERTa classifiers #695

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Default compilation for BERT/RoBERTa classifiers #695

merged 2 commits into from
Feb 1, 2023

Conversation

jbischof
Copy link
Contributor

@jbischof jbischof commented Jan 25, 2023 •
edited
Loading

Pilot to offer intelligent default compilation for all task models. Part of #619

Right now we only have defaults validated for BERT and RoBERTa classifers (link), but we can prioritize adding more in the future. We will never have 100% coverage of all tasks, but it's best to minimize user confusion.

@mattdangerw mattdangerw requested a review from fchollet January 26, 2023 20:56
chenmoneygithub
chenmoneygithub reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM overall.

The only issue is the default jit_compile=True, we should probably also add detection on if XLA is applicable. There are some known issues on M1 Mac and DirectML, on which XLA causes issues.

keras_nlp/models/roberta/roberta_classifier.py Show resolved Hide resolved
keras_nlp/models/bert/bert_classifier.py Outdated Show resolved Hide resolved
@jbischof jbischof marked this pull request as ready for review January 31, 2023 21:48
mattdangerw
mattdangerw approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbischof jbischof mentioned this pull request Feb 1, 2023
Closed
5 tasks
@jbischof jbischof merged commit 8581352 into keras-team:master Feb 1, 2023
@jbischof jbischof mentioned this pull request Feb 1, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenmoneygithub chenmoneygithub chenmoneygithub left review comments

@mattdangerw mattdangerw mattdangerw approved these changes

@fchollet fchollet Awaiting requested review from fchollet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbischof @mattdangerw @chenmoneygithub