Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import rouge_scorer directly from rouge_score package #691

Merged
merged 1 commit into from
Jan 25, 2023
Merged

import rouge_scorer directly from rouge_score package #691

merged 1 commit into from
Jan 25, 2023

Conversation

sampathweb
Copy link
Collaborator

@sampathweb sampathweb commented Jan 25, 2023 •
edited
Loading

Change import to from x import y since only one function is imported

@jbischof
Copy link
Contributor

Thanks @sampathweb! Could you add a brief description of the underlying issue?

@mattdangerw
Copy link
Member

ty!

@sampathweb
Copy link
Collaborator Author

Thanks @sampathweb! Could you add a brief description of the underlying issue?

Done and also addressed offline.

@mattdangerw mattdangerw merged commit 94b5a80 into keras-team:master Jan 25, 2023
mattdangerw pushed a commit that referenced this pull request Jan 25, 2023
@sampathweb @mattdangerw
Change import of to directly import (#691)
dec9614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw Awaiting requested review from mattdangerw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sampathweb @jbischof @mattdangerw