Conditionally import tf_text everywhere #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to allow an installation without tf-text on MacOS, as tf-text has no pypi binaries for m1 chips.
jbischof
reviewed
Jan 21, 2023
| @@ -236,6 +241,8 @@ def __init__( | |||
| truncate="round_robin", | |||
| **kwargs, | |||
| ): | |||
| assert_tf_text_installed(self.__class__.__name__) | |||
There was a problem hiding this comment.
Does this surface a readable error message? Is this the only place we need to do this?
There was a problem hiding this comment.
If you search code, we do this in already 8 other places, this is a spot we missed. And yes, this just raises an error, utility so our language could stay consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow an installation without tf-text on MacOS, as tf-text has no pypi binaries for m1 chips.