Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FNet Presets #659

Merged
merged 7 commits into from
Jan 18, 2023
Merged

Add FNet Presets #659

merged 7 commits into from
Jan 18, 2023

Conversation

abheesht17
Copy link
Collaborator

@abheesht17 abheesht17 commented Jan 14, 2023 •
edited
Loading

jbischof
jbischof suggested changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some nits!

keras_nlp/models/deberta_v3/deberta_v3_presets.py Outdated Show resolved Hide resolved
keras_nlp/models/f_net/f_net_tokenizer.py Outdated Show resolved Hide resolved
keras_nlp/models/f_net/f_net_tokenizer.py Outdated Show resolved Hide resolved
@abheesht17 abheesht17 mentioned this pull request Jan 17, 2023
Closed
mattdangerw
mattdangerw reviewed Jan 18, 2023
View reviewed changes
keras_nlp/models/f_net/f_net_preprocessor.py Outdated
return super().from_preset(preset, **kwargs)


FNetPreprocessor.from_preset.__func__.__doc__ = Preprocessor.from_preset.__doc__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed now, and the from_preset redefinition

mattdangerw
mattdangerw approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattdangerw mattdangerw merged commit 34f812f into keras-team:master Jan 18, 2023
jbischof
jbischof reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbischof jbischof jbischof requested changes

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abheesht17 @jbischof @mattdangerw