Rename preset IDs for consistency #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full list of preset names after the rename... bert_tiny_en_uncased
bert_tiny_en_uncased_sst2
bert_small_en_uncased
bert_medium_en_uncased
bert_base_en_uncased
bert_base_en
bert_base_zh
bert_base_multi
bert_large_en_uncased
bert_large_en
distil_bert_base_en_uncased
distil_bert_base_en
distil_bert_base_multi
roberta_base_en
roberta_large_en
xlm_roberta_base_multi
xlm_roberta_large_multi |
jbischof
approved these changes
Dec 27, 2022
STYLE_GUIDE.md
Outdated
| - All preset names should include the language of the pretraining data. If three | ||
| or more language are supported, the preset name should include `"multi"` (not | ||
| the single letter "m"). | ||
| - If a preset lowercases input for cased based language, the preset name should |
STYLE_GUIDE.md
Outdated
| - No configuration in names. E.g. use "bert_base" instead of | ||
| "bert_L-12_H-768_A-12". | ||
|
|
||
| When in doubt, readability and usability of names should win out! |
There was a problem hiding this comment.
"When in doubt, readability should win out!" is catchier. Just saying.
mattdangerw
force-pushed
the
preset-rename
branch
2 times, most recently
from
677d51b to
9820d1d
Compare
And start to add rules we would like to follow to our style guide.
mattdangerw
force-pushed
the
preset-rename
branch
from
9820d1d to
ef6e8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And start to add rules we would like to follow to our style guide.