Cherry picks 0.3 #454
Merged
Cherry picks 0.3 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more test cases. Co-authored-by: jessechancy <[email protected]> add merge file Make cache a tf module Delete testdata address comments address comments fix docstring fix docstring
Before this fix, the detokenize function would squish everything down into a single string. So it would not preserve the structure of what was passed in.
* Support string output for BytePairTokenizer * Add unit test * Minor edit
Windows nightlies have been broken for a few days now. Probably related, core Tensorflow is dropping native Windows support for anything but tensorflow-cpu (which we don't install by default) as of the upcoming tf release (2.11). Both core tensorflow and our development guide recommend WSL2. I think the simplest solution here is to stop running windows CI and continue recommending WSL2 for running on windows.
…s-team#383) * Improve MacOS support * Conditionally import tensorflow_text everywhere * Use requirements files for continuous testing * Fix logs * Bug fixes and improvement for linux testing * Typo fix * Address review comments
chenmoneygithub
approved these changes
Nov 10, 2022
In keeping with other layers, we should not rely on tf text being installed to import the library (this is useful for building keras.io for example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bring in a few cherry picks for a 0.3.1 point release: