Remove einops dep #2006
Merged
Remove einops dep #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't add a new dependency for just to reshape calls. We can do this the less readable way for now.
mattdangerw
force-pushed
the
remove-einops
branch
from
d1f78f0 to
318c73c
Compare
mattdangerw
requested review from
divyashreepathihalli,
SamanehSaadat and
jeffcarp
jeffcarp
approved these changes
Dec 5, 2024
|
The bug is that this dependency is imported unconditionally, but not a actual pip depedency of the package. But I think the right solution is to avoid the new depedency for now. This is not important enough of a usage to warrant a new library dep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't add a new dependency for just two reshape calls. We can do this the less readable way for now.