Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror all weights on HF from Kaggle #1959

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Mirror all weights on HF from Kaggle #1959

merged 7 commits into from
Oct 30, 2024

Conversation

divyashreepathihalli
Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli commented Oct 29, 2024 •
edited
Loading

  • Automated Detection of Missing Uploads on HF assuming Kaggle is our source of truth
  • The JSON file keeps track of the most up to date uploaded presets on HuggingFace
  • Everytime the mirroring script is run, the missing presets are uploaded on HF and the tracking JSON is updated
  • Gemma model preset uploads are skipped since the keras variants are uploaded through the main Google account

@github-actions github-actions bot added the Gemma Gemma model specific issues label Oct 29, 2024
@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Oct 29, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Oct 29, 2024
SamanehSaadat
SamanehSaadat reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Divya! The automatic sync would be very helpful!
Just left some nit comments.

tools/mirror_weights_on_hf.py Outdated Show resolved Hide resolved
tools/mirror_weights_on_hf.py Outdated Show resolved Hide resolved
tools/mirror_weights_on_hf.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to run this script automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to set it up to run automatically once a day. For now it is run manually.

tools/hf_uploaded_presets.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have already been uploaded?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is right

SamanehSaadat
SamanehSaadat approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Divya!

@divyashreepathihalli divyashreepathihalli merged commit 316775f into keras-team:master Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamanehSaadat SamanehSaadat SamanehSaadat approved these changes

@mattdangerw mattdangerw Awaiting requested review from mattdangerw

Assignees
No one assigned
Labels
Gemma Gemma model specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyashreepathihalli @SamanehSaadat @kokoro-team