[RetinaNet] Image Converter and ObjectDetector #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neeli/keras-hub into sineeli/add-retinanet-phase-2
There was a problem hiding this comment.
Thanks for the PR @sineeli!! Looks generally good!! I have left a few comments.
Also, I want to make sure the -The code usage is updated to reflect the correct implementation - https://docs.google.com/document/d/15FUEP_vNehwLWJLragXhPFkYcbmmpbo0NYh5vL6q1xA/edit?tab=t.0
fchollet
reviewed
Oct 3, 2024
|
Kept some layers |
| "max_level": 7, | ||
| "num_scales": 3, | ||
| "aspect_ratios": [0.5, 1.0, 2.0], | ||
| "anchor_size": 8, | ||
| }, | ||
| input_data={ |
There was a problem hiding this comment.
define input_data also in setup()
There was a problem hiding this comment.
input_data varies in each test_case so kept it separately also how we assert changes
- Correct test cases.
…et format from preprocessor
… sineeli/add-retinanet-phase-2
divyashreepathihalli
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers preprocessor for RetinaNet object detector and RetinaNet model itself. #1756
ImageObjectDetectorImageObjectDetectorPreprocessorRetinaNetObjectDetectorRetinaNetObjectDetectorPreprocessorRetinaNetImageConverter