Expunge include_rescaling from backbones #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyashreepathihalli
approved these changes
Sep 21, 2024
|
Thanks! Tests looking good. I'll regenerate the resnet preset, update the links, and land this. |
mattdangerw
force-pushed
the
rescaling-move
branch
2 times, most recently
from
9fcfe41 to
cf4a335
Compare
Since our models include built in preprocessing, it is much clearer for this rescaling to happen in the preprocessing layers.
mattdangerw
force-pushed
the
rescaling-move
branch
from
cf4a335 to
411a4bf
Compare
Merged
|
Should we rename this layer to something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our models include built in preprocessing, it is much clearer for this rescaling to happen in the preprocessing layers.