Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to the position embedding docs #180

Merged
merged 1 commit into from
May 13, 2022
Merged

Minor improvements to the position embedding docs #180

merged 1 commit into from
May 13, 2022

Conversation

mattdangerw
Copy link
Member

I'm using this as an example in a code style guide, so adding a few
minor fixes I found while doing so.

@mattdangerw
Minor improvements to the position embedding docs
d72c8ef 
I'm using this as an example in a code style guide, so adding a few
minor fixes I found while doing so.
chenmoneygithub
chenmoneygithub approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit 99922f8 into keras-team:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @chenmoneygithub