Fix compatibility for earlier versions of Keras #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james77777778
force-pushed
the
fix-compatibility
branch
from
bb853b7 to
9a45a68
Compare
james77777778
changed the title
james77777778
changed the title
mattdangerw
reviewed
Jul 10, 2024
james77777778
force-pushed
the
fix-compatibility
branch
3 times, most recently
from
2f5600d to
f7c40e3
Compare
james77777778
force-pushed
the
fix-compatibility
branch
from
f7c40e3 to
7f730ad
Compare
james77777778
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new matrix of runners to test KerasNLP with Keras 3.1.0
Now the code should run flawlessly with Keras 3.1.0
(Keras 3.0.x failed due to the absence of the
keras.treeAPI, and it is difficult to make it compatible).However, quantization only works correctly with Keras >= 3.4.0 using
DTypePolicyMap. Therefore, version checks have been included as well.cc @fchollet @mattdangerw
EDITED:
All tests passed. If users are not using the quantization API, they can use any version of Keras from
3.1.0to the latest.