Improve error handling for missing TensorFlow dependency in keras_nlp. #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Apr 22, 2024
| import tensorflow as tf | ||
| except ImportError: | ||
| raise ImportError( | ||
| "To use `keras_nlp`, please install Tensorflow: `pip install tensorflow`. " |
There was a problem hiding this comment.
Tensorflow -> TensorFlow
keras_nlp/utils/tensor_utils.py
Outdated
| except ImportError: | ||
| raise ImportError( | ||
| "To use `keras_nlp`, please install Tensorflow: `pip install tensorflow`. " | ||
| "Tensorflow package is required for data preprocessing with any backend." |
There was a problem hiding this comment.
Tensorflow package -> The TensorFlow package
fchollet
approved these changes
Apr 22, 2024
SamanehSaadat
added
kokoro:force-run
|
The test failures are not related to this PR and the fix is on the way in #1593. |
|
Installing keras-nlp can be quite challenging, especially for Windows users. To improve the experience, it's crucial to include precise steps and OS requirements in the readme section. Since TensorFlow text doesn't function on Windows, it's essential to address this issue upfront. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: user doesn't have
tensorflowinstalled and doesn't expect to get error as they're usingpytorchbackend.