Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accept a string dtype for unicode tokenizer #147

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Don't accept a string dtype for unicode tokenizer #147

merged 2 commits into from
Apr 30, 2022

Conversation

mattdangerw
Copy link
Member

This tokenizer cannot output strings.

@mattdangerw
Don't accept a string dtype for unicode tokenizer
7baff24 
This tokenizer cannot output strings.
chenmoneygithub
chenmoneygithub reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - how this dype is used in tokenizer? I did some search and found no explicit reference.

@mattdangerw
Copy link
Member Author

Right, we need to cast the output to the desired dype as well (as it appears tf.strings.unicode_decode only supports int32).

@mattdangerw mattdangerw merged commit 7e678e4 into keras-team:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenmoneygithub chenmoneygithub chenmoneygithub left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @chenmoneygithub