Adds Kokoro Build script for Keras-NLP GPU tests #1355
Conversation
| cd "src/github/keras" | ||
| pip install -U pip setuptools | ||
|
|
||
| if [ "$KERAS_BACKEND" == "tensorflow" ] |
There was a problem hiding this comment.
When I was working on updates for our old cloud build (which I will now close), I added this.
https://github.com/keras-team/keras-nlp/pull/1325/files#diff-656afe8203d34a7914ea21b11d467eddd6295aabf2ca2cdee2124c63984e680f
What to you think about adding that instead? It is kind of nice to be able to run pytest blah --check_gpu locally as well (to sanity check that you are running with an accelerator).
If we did that could keep our bash scripts simpler, which is always a plus.
There was a problem hiding this comment.
Makes sense. Added.
kokoro/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| CI to run on PR and merge to Master. | |||
There was a problem hiding this comment.
Not important, but up to now we have kept all our build configuration as private files .github, .vscode, .cloudbuild. Is it possible to do the same here with .kokoro? Or would that break tooling?
There was a problem hiding this comment.
That makes sense. It will not break tooling, but I need to update config and get approval from Kokoro. I can do that if we prefer to do that or we can do that in a subsequent change once we confirm everything is working.
There was a problem hiding this comment.
Renamed to .kokoro
Adds Kokoro Config and build script for Continuous (nightly) and Presubmit (PR) builds.